Skip to content

fix: issue #475 #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Aug 13, 2021

@maxceem please review

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yoution. It works good, I only would like to make some updates for the code.

  1. The way it is implemented now, the resume would be downloaded by the TaaS API and then sent to the client by the TaaS API. Can we avoid downloading resume TaaS API, and just redirect to the resume like this https://expressjs.com/en/api.html#res.redirect ?

  2. Let's add a title to the email:

    image

Also, please check comments to the code below.

@yoution
Copy link
Contributor Author

yoution commented Aug 13, 2021

@maxceem
Let's add a title to the email:, the html is using table layout, it is a little complex, is there any web tools to automatically create the layout?

@maxceem
Copy link
Contributor

maxceem commented Aug 13, 2021

@yoution we already support title, just pass description: "Client Viewed Resume" inside the email data and it would be inserted inside email here https://github.com/topcoder-platform/taas-apis/blob/feature/notifications-api/data/notifications-email-template.html#L75.

@yoution yoution requested a review from maxceem August 13, 2021 13:17
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @yoution works good as per local testing.

@maxceem maxceem merged commit 8e8830e into topcoder-platform:feature/notifications-api Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants