Send Weekly Surveys

[yoution]

@maxceem please merge

[yoution]

@maxceem please review

[maxceem]

@yoution

I'm trying to test sending survey locally, though I'm getting errors like these

do you have some idea what could be the reason? I'm using the config from the validation guide.

Also, regarding this update in code I'm not sure how this would help, as for me to fix this issue "As per logs in Run 02, encountered "ERROR : Error : socket hang up" during the sending of first survey. There's no exception handler and theres no way to recover (other than to restart or reset cron)." we have to wrap each of await partiallyUpdateWorkPeriod inside additional try {} catch () {} so we catch any error which happens during updating work period too.

[yoution]

@maxceem can we change the date format to d/m/yyyy to dd/mm/yyyy

[maxceem]

@yoution actually this format we have been already using for such surveys, so I don’t think we can change it. Any issues with it?

[yoution]

you can change to dd/mm/yyyy firstly, I will debug the code, wait a moment

[maxceem]

Thanks, I’ll check tomorrow morning using this format, though ideally we need to use existent format.

[yoution]

I can not reproduce the error locally,
https://github.com/yoution/taas-apis/blob/feature/weekly-surveys/src/common/surveyMonkey.js#L48, is this line?

[yoution]

@maxceem please ignore the format error, maybe the surveyId is not correct?

[yoution]

@maxceem for socket hang up error, maybe

the tc-bus-api should update

[maxceem]

@yoution your config you shared above helped me, thanks! (btw, I've removed it from the comment)

The only one thing left: the app should not crash is some error happens.
For now, if some error happens during partiallyUpdateWorkPeriod() the whole app crashes.
To reproduce the issue I throw error:

async function partiallyUpdateWorkPeriod (currentUser, id, data) {
  throw new Error('some error during WP update')
  return updateWorkPeriod(currentUser, id, data)
}

So what should be done to prevent this I think:

1. Don't make this change to the code:

   I'm not sure why this change was done, if there is any reason for this, please let me know.

   

2. Each partiallyUpdateWorkPeriod() during sending serveys should be wrapped into try {} catch so error happened during partiallyUpdateWorkPeriod should be catched and just logged by logger. But don't break the whole app.

[yoution]

@maxceem for 1. why did I change the code, because when error happened in partiallyUpdateWorkPeriod ,
but actually, the survery has been sent successfully, when it will go into the error, it will set the sendSurvey: false and sentSurveyError: e
2. I will fix soon

[maxceem]

Thanks for the quick updates @yoution all works good now.