Skip to content

fix: script to import job from RCRM #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

eisbilir
Copy link
Member

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eisbilir it works perfectly.

Though as per diff it looks like files were completely updated, even though only small parts of them were updated. I guess it is because inside these files line endings have been changed from LF to CRLF.

Is it possible to bring back LF line endings to the files, so in diff we would only see the real changes? This would be also good for consistency, as inside the repo we usually use LF line endings.

Demo video https://monosnap.com/file/nC9oyKqQnXPpVhoyd83HbdPLDAxzKj

@eisbilir eisbilir force-pushed the fix/job-import-script branch from 86b1b7c to 60d476e Compare July 29, 2021 14:07
@eisbilir eisbilir requested a review from maxceem July 29, 2021 14:08
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution thanks!

@maxceem maxceem merged commit f559204 into topcoder-platform:dev Jul 29, 2021
@eisbilir eisbilir deleted the fix/job-import-script branch July 31, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants