Role api fixes #384
Merged
Role api fixes #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikolay83
this should fix #381 and #375
@maxceem
we need to allow not logged in users to use GET taas-teams/sendRoleSearchRequest endpoint, but we also need to see user details when this endpoint called by an authenticated user. To make it possible I had to add a new middleware at
app-routes.js. Same as how it's done here: https://github.com/topcoder-platform/challenge-api/blob/develop/app-routes.js#L71-L94Although this new middleware will only run for unprotected endpoints and almost all of the endpoints in taas-apis are protected, I think It would be good if you check this.