fix: remove jobIds from query #310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
reviewed
Jun 7, 2021
Comment on lines
61
to
+66
| req.query.jobIds = req.body.jobIds | ||
| } | ||
| const result = await service.searchJobs(req.authUser, req.query) | ||
| if (req.query.jobIds) { | ||
| delete req.query.jobIds | ||
| } |
There was a problem hiding this comment.
The current logic to add and then to delete fields is a bit hard to follow. It would be nice if logic would more straightforward, for example like this:
const query = {
...req.query,
// we can pass jobIds in `body` or in `query`
jobIds: _.get(req, 'body.jobIds', req.query.jobIds)
}
const result = await service.searchJobs(req.authUser, query)
There was a problem hiding this comment.
I agree, maybe simply check body for it, if jobIds are not present, we can avoid to pass jobIds to the criteria or pass an empty array. By looking at the service method, seems both would be fine.
|
fixed by #315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After header links for pagination added it returns 502 error if jobIds array has more than ~40 ids.
Especially when all of the first,next and last links are exist.
when we make page=2, the prev-page link added to the header