Skip to content

fix: resource booking search issues #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2021
Merged

fix: resource booking search issues #278

merged 2 commits into from
Jun 1, 2021

Conversation

eisbilir
Copy link
Member

demo data is improved with various dates, ids, userHandles, etc..
using postman folder: Resource Bookings > Extended Search Scenarios after importing demo data will help to test every possible combination of search criterias.

@maxceem
Copy link
Contributor

maxceem commented May 31, 2021

@eisbilir when I run npm run local:init I get error importData ERROR : bulk.flatMap is not a function, see screenshot https://monosnap.com/file/oDZZK3ycMNVaRsQ38C9AySGGM5hlHK

Do you have the same issue, or npm run local:init works good to you?

@eisbilir
Copy link
Member Author

eisbilir commented May 31, 2021

@maxceem it works good for me https://prnt.sc/13mx1a4
Is this error new for you with npm run local:init ?
and you are on node 12 right?

@maxceem
Copy link
Contributor

maxceem commented May 31, 2021

my bad, I used node 10, works good with node 12

thank you @eisbilir

@eisbilir
Copy link
Member Author

I had to resolve conflicts after this pull #279

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eisbilir thank you resolving the conflicts with DEV.

It works good for me as per local testing. I would merge it to DEV and ask QA team to check it one more time.

@maxceem maxceem merged commit f1ea6f8 into topcoder-platform:dev Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants