Skip to content

feat(job-service): accept roles array #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2d0e55b
Merge pull request #222 from topcoder-platform/dev-wp
nkumar-topcoder Apr 26, 2021
8f55b21
Merge pull request #233 from topcoder-platform/dev
urwithat May 3, 2021
1fce5a2
Merge pull request #234 from topcoder-platform/dev
urwithat May 3, 2021
2021d76
Merge pull request #247 from topcoder-platform/dev
urwithat May 17, 2021
2ad5544
Merge pull request #252 from topcoder-platform/dev
urwithat May 17, 2021
dc1cfa4
Add JobIds to /jobs endpoint:30185451
May 22, 2021
8b55765
fix: checking if member of project
eisbilir May 22, 2021
de67dbe
Merge pull request #266 from topcoder-platform/feature/role-intake
urwithat May 26, 2021
f5ae061
Merge branch 'dev' into feature/add-jobIds
maxceem May 26, 2021
1320187
Merge pull request #261 from eisbilir/dev
maxceem May 27, 2021
edbff4e
Merge pull request #264 from topcoder-platform/feature/add-jobIds
sushilshinde May 27, 2021
b16a6fc
chore: use v5/members instead of v3/members
maxceem May 27, 2021
a7d3d17
Merge pull request #271 from topcoder-platform/feature/use-v5-members
nkumar-topcoder May 27, 2021
3ede43e
fix: addded new 'offred' status
sushilshinde May 27, 2021
1616543
Merge pull request #273 from topcoder-platform/statuses-change
sushilshinde May 27, 2021
93495aa
Updated Swagger for jobCandidate statuses
sushilshinde May 27, 2021
8446c87
Update swagger.yaml
sushilshinde May 27, 2021
79e7783
Merge pull request #274 from topcoder-platform/statuses-change
sushilshinde May 27, 2021
0304e68
feat(job-service): accept `roles` array
cagdas001 May 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports = {

TOPCODER_USERS_API: process.env.TOPCODER_USERS_API || 'https://api.topcoder-dev.com/v3/users',
// the api to find topcoder members
TOPCODER_MEMBERS_API: process.env.TOPCODER_MEMBERS_API || 'https://api.topcoder-dev.com/v3/members',
TOPCODER_MEMBERS_API: process.env.TOPCODER_MEMBERS_API || 'https://api.topcoder-dev.com/v5/members',
// rate limit of requests to user api
MAX_PARALLEL_REQUEST_TOPCODER_USERS_API: process.env.MAX_PARALLEL_REQUEST_TOPCODER_USERS_API || 100,

Expand Down
12 changes: 6 additions & 6 deletions data/demo-data.json
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
"jobCandidateId": "881a19de-2b0c-4bb9-b36a-4cb5e223bdb5",
"googleCalendarId": null,
"customMessage": null,
"xaiTemplate": "interview-30",
"templateUrl": "interview-30",
"round": 1,
"startTimestamp": null,
"attendeesList": null,
Expand Down Expand Up @@ -213,7 +213,7 @@
"jobCandidateId": "827ee401-df04-42e1-abbe-7b97ce7937ff",
"googleCalendarId": "dummyId",
"customMessage": "This is a custom message",
"xaiTemplate": "interview-30",
"templateUrl": "interview-30",
"round": 2,
"startTimestamp": null,
"attendeesList": null,
Expand All @@ -228,7 +228,7 @@
"jobCandidateId": "827ee401-df04-42e1-abbe-7b97ce7937ff",
"googleCalendarId": null,
"customMessage": null,
"xaiTemplate": "interview-30",
"templateUrl": "interview-30",
"round": 1,
"startTimestamp": null,
"attendeesList": null,
Expand Down Expand Up @@ -257,7 +257,7 @@
"jobCandidateId": "a4ea7bcf-5b99-4381-b99c-a9bd05d83a36",
"googleCalendarId": "dummyId",
"customMessage": "This is a custom message",
"xaiTemplate": "interview-30",
"templateUrl": "interview-30",
"round": 3,
"startTimestamp": null,
"attendeesList": [
Expand All @@ -275,7 +275,7 @@
"jobCandidateId": "a4ea7bcf-5b99-4381-b99c-a9bd05d83a36",
"googleCalendarId": "dummyId",
"customMessage": "This is a custom message",
"xaiTemplate": "interview-30",
"templateUrl": "interview-30",
"round": 2,
"startTimestamp": null,
"attendeesList": [
Expand All @@ -293,7 +293,7 @@
"jobCandidateId": "a4ea7bcf-5b99-4381-b99c-a9bd05d83a36",
"googleCalendarId": null,
"customMessage": null,
"xaiTemplate": "interview-30",
"templateUrl": "interview-30",
"round": 1,
"startTimestamp": null,
"attendeesList": null,
Expand Down
107 changes: 107 additions & 0 deletions docs/Topcoder-bookings-api.postman_collection.json
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,113 @@
},
"response": []
},
{
"name": "search jobs with request body",
"protocolProfileBehavior": {
"disableBodyPruning": true
},
"request": {
"method": "GET",
"header": [
{
"key": "Authorization",
"type": "text",
"value": "Bearer {{token_bookingManager}}"
}
],
"body": {
"mode": "raw",
"raw": "{\r\n \"jobIds\": [\"{{jobId}}\",\"{{jobIdCreatedByM2M}}\"]\r\n}",
"options": {
"raw": {
"language": "json"
}
}
},
"url": {
"raw": "{{URL}}/jobs",
"host": [
"{{URL}}"
],
"path": [
"jobs"
],
"query": [
{
"key": "page",
"value": "0",
"disabled": true
},
{
"key": "perPage",
"value": "3",
"disabled": true
},
{
"key": "sortBy",
"value": "id",
"disabled": true
},
{
"key": "sortOrder",
"value": "asc",
"disabled": true
},
{
"key": "projectId",
"value": "21",
"disabled": true
},
{
"key": "externalId",
"value": "1212",
"disabled": true
},
{
"key": "description",
"value": "Dummy",
"disabled": true
},
{
"key": "startDate",
"value": "2020-09-27T04:17:23.131Z",
"disabled": true
},
{
"key": "resourceType",
"value": "Dummy Resource Type",
"disabled": true
},
{
"key": "skill",
"value": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
"disabled": true
},
{
"key": "rateType",
"value": "hourly",
"disabled": true
},
{
"key": "status",
"value": "sourcing",
"disabled": true
},
{
"key": "workload",
"value": "full-time",
"disabled": true
},
{
"key": "title",
"value": "dummy",
"disabled": true
}
]
}
},
"response": []
},
{
"name": "search jobs with with m2m all",
"request": {
Expand Down
20 changes: 20 additions & 0 deletions docs/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@ paths:
type: string
enum: ["sourcing", "in-review", "assigned", "closed", "cancelled"]
description: The rate type.
requestBody:
content:
application/json:
schema:
$ref: "#/components/schemas/JobSearchBody"
responses:
"200":
description: OK
Expand Down Expand Up @@ -603,6 +608,12 @@ paths:
"cancelled",
"interview",
"topcoder-rejected",
"applied",
"rejected-pre-screen",
"skills-test",
"phone-screen",
"job-closed",
"offered"
]
description: The job candidate status.
- in: query
Expand Down Expand Up @@ -3363,6 +3374,15 @@ components:
type: string
example: "topcoder user"
description: "The user who updated the job last time.(Will get the user info from the token)"
JobSearchBody:
properties:
jobIds:
type: array
items:
type: string
format: uuid
description: "The array of job ids"

JobRequestBody:
required:
- projectId
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Joi.rateType = () => Joi.string().valid('hourly', 'daily', 'weekly', 'monthly')
Joi.jobStatus = () => Joi.string().valid('sourcing', 'in-review', 'assigned', 'closed', 'cancelled')
Joi.resourceBookingStatus = () => Joi.string().valid('placed', 'closed', 'cancelled')
Joi.workload = () => Joi.string().valid('full-time', 'fractional')
Joi.jobCandidateStatus = () => Joi.string().valid('open', 'placed', 'selected', 'client rejected - screening', 'client rejected - interview', 'rejected - other', 'cancelled', 'interview', 'topcoder-rejected', 'applied','rejected-pre-screen','skills-test','skills-test','phone-screen','job-closed')
Joi.jobCandidateStatus = () => Joi.string().valid('open', 'placed', 'selected', 'client rejected - screening', 'client rejected - interview', 'rejected - other', 'cancelled', 'interview', 'topcoder-rejected', 'applied','rejected-pre-screen','skills-test','skills-test','phone-screen','job-closed','offered')
Joi.title = () => Joi.string().max(128)
Joi.paymentStatus = () => Joi.string().valid('pending', 'partially-completed', 'completed', 'cancelled')
Joi.xaiTemplate = () => Joi.string().valid(...allowedXAITemplate)
Expand Down
33 changes: 14 additions & 19 deletions src/common/helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ esIndexPropertyMapping[config.get('esConfig.ES_INDEX_JOB')] = {
rateType: { type: 'keyword' },
workload: { type: 'keyword' },
skills: { type: 'keyword' },
roles: { type: 'keyword' },
status: { type: 'keyword' },
isApplicationPageActive: { type: 'boolean' },
createdAt: { type: 'date' },
Expand Down Expand Up @@ -1304,21 +1305,18 @@ async function getMemberDetailsByHandles(handles) {
}
const token = await getM2MToken();
const res = await request
.get(`${config.TOPCODER_MEMBERS_API}/_search`)
.get(`${config.TOPCODER_MEMBERS_API}/`)
.query({
query: _.map(
handles,
(handle) => `handleLower:${handle.toLowerCase()}`
).join(' OR '),
fields: 'userId,handle,firstName,lastName,email',
'handlesLower[]': handles.map(handle => handle.toLowerCase()),
fields: 'userId,handle,handleLower,firstName,lastName,email',
})
.set('Authorization', `Bearer ${token}`)
.set('Accept', 'application/json');
localLogger.debug({
context: 'getMemberDetailsByHandles',
message: `response body: ${JSON.stringify(res.body)}`,
});
return _.get(res.body, 'result.content');
return res.body;
}

/**
Expand All @@ -1327,17 +1325,14 @@ async function getMemberDetailsByHandles(handles) {
* @param {String} handle the user handle
* @returns {Object} the member details
*/
async function getV3MemberDetailsByHandle(handle) {
const token = await getM2MToken();
const res = await request
.get(`${config.TOPCODER_MEMBERS_API}/${handle}`)
.set('Authorization', `Bearer ${token}`)
.set('Accept', 'application/json');
localLogger.debug({
context: 'getV3MemberDetailsByHandle',
message: `response body: ${JSON.stringify(res.body)}`,
});
return _.get(res.body, 'result.content');
async function getMemberDetailsByHandle(handle) {
const [memberDetails] = await getMemberDetailsByHandles([handle])

if (!memberDetails) {
throw new errors.NotFoundError(`Member details are not found by handle "${handle}".`)
}

return memberDetails
}

/**
Expand Down Expand Up @@ -1756,7 +1751,7 @@ module.exports = {
getAuditM2Muser,
checkIsMemberOfProject,
getMemberDetailsByHandles,
getV3MemberDetailsByHandle,
getMemberDetailsByHandle,
getMemberDetailsByEmails,
createProjectMember,
listProjectMembers,
Expand Down
3 changes: 3 additions & 0 deletions src/controllers/JobController.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ async function deleteJob (req, res) {
* @param res the response
*/
async function searchJobs (req, res) {
if (req.body && req.body.jobIds) {
req.query.jobIds = req.body.jobIds
}
const result = await service.searchJobs(req.authUser, req.query)
helper.setResHeaders(req, res, result)
res.send(result.result)
Expand Down
3 changes: 3 additions & 0 deletions src/models/Job.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ module.exports = (sequelize) => {
type: Sequelize.JSONB,
allowNull: false
},
roles: {
type: Sequelize.ARRAY(Sequelize.UUID)
},
status: {
type: Sequelize.STRING(255),
allowNull: false
Expand Down
Loading