Add new field isApplicationPageActive to the Job model
#169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
approved these changes
Mar 1, 2021
maxceem
reviewed
Mar 1, 2021
| up: queryInterface => { | ||
| return Promise.all([ | ||
| queryInterface.sequelize.query('ALTER TABLE bookings.jobs ADD is_application_page_active BOOLEAN NOT NULL DEFAULT false'), | ||
| queryInterface.sequelize.query('UPDATE bookings.jobs SET is_application_page_active=false WHERE is_application_page_active is NULL'), |
There was a problem hiding this comment.
I think we don't need this second query UPDATE bookings.jobs SET is_application_page_active=false WHERE is_application_page_active is NULL as the previous one would already set all the values bye default, and it also sets NOT NUL so there cannot be null values.
But it doesn't harm either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification
isApplicationPageActivein Job creationSet the value of
isApplicationPageActiveby m2m user when creating a job:Setting the value of
isApplicationPageActiveby adminstrator when creating a job results in 403 error:Setting the value of
isApplicationPageActivetonullwhen creating a job is forbidden:isApplicationPageActivein Job updatingUpdate the value of
isApplicationPageActiveby m2m user when updating a job:Updating the value of
isApplicationPageActiveby adminstrator when updating a job results in 403 error:Updating the value of
isApplicationPageActivetonullwhen updating a job is forbidden: