Skip to content

Winner Submission of the challenge Topcoder TaaS API - Data Scripts #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

shailesh-02
Copy link

@shailesh-02 shailesh-02 commented Feb 3, 2021

Created scripts for importing and indexing data to ES

Winner submission from the challenge https://www.topcoder.com/challenges/8a2bed05-e102-47db-945c-f165438fb68e?tab=details with final fixes:

  1. Check https://prnt.sc/xt0tz0. Such warning should be removed.
  2. indexing uses different IDs than DB and not UUID. This has the side effect of the API not able to load related documents like job#candidates and if re-indexing with ID later, it will add duplicate records.
  3. At the moment time is always shown in milliseconds for average time, time spend and time left. Instead of always showing milliseconds, let's show time so it's easier to read for humans like:
    "1 year 3 months 2 weeks 7 days 16 hours 58 minutes 17 seconds 856 milliseconds"
  4. Merge with the latest dev branch and resolve conflicts

@maxceem maxceem changed the title final fixes Winner Submission of the challenge Topcoder TaaS API - Data Scripts Feb 3, 2021
@maxceem maxceem changed the base branch from dev to feature/data-scripts February 3, 2021 09:08
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shailesh-02. Final fixes done perfectly as per local testing.

@maxceem maxceem merged commit 2fd35a1 into topcoder-platform:feature/data-scripts Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants