[$10] When a job start date is not defined, the job start date in the slack notification should be shown 'TBD'

[sdgun]

Steps
Select a candidate to a job from TAAS app(position should not have a start date)
Check the slack notification on 'Job Candidate is Selected'

Job Start Date: undefined in the slack notification, it should be 'TBD'

[maxceem]

Sum up:

If Job start date is not defined, we have to show TBD. In all the emails, in-app and slack notifications where we show Job Start Date.

@yoution would you like to handle this change?

[yoution]

@maxceem please assign to me

[yoution]

@maxceem I am not familiar with the all process, we should change the code here?
https://github.com/topcoder-platform/taas-es-processor/blob/dev/src/services/JobCandidateProcessorService.js#L139
if startDate is null, set to TBD

[maxceem]

@yoution no, we send emails, in-app and slack notifications like this https://github.com/topcoder-platform/taas-apis/blob/dev/src/eventHandlers/JobCandidateEventHandler.js#L175-L218 and like this https://github.com/topcoder-platform/taas-apis/blob/dev/src/services/NotificationsSchedulerService.js#L415-L427.

You can find all such places by sendNotification and by NOTIFICATIONS_CREATE_TOPIC. In all these places we send notifications and we pass some data. In case we pass job.startDate we have to check if job.startDate is not defined or null and then send inside notification TBD.

For example here https://github.com/topcoder-platform/taas-apis/blob/dev/src/eventHandlers/JobCandidateEventHandler.js#L207, here https://github.com/topcoder-platform/taas-apis/blob/dev/src/eventHandlers/JobCandidateEventHandler.js#L165 and here https://github.com/topcoder-platform/taas-apis/blob/dev/src/eventHandlers/JobEventHandler.js#L94.

Maybe there are some other places.

Does it help?

[maxceem]

Challenge https://www.topcoder.com/challenges/25ae68d9-7a20-4b9b-a43e-f443d5e39c53 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[maxceem]

Challenge https://www.topcoder.com/challenges/25ae68d9-7a20-4b9b-a43e-f443d5e39c53 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X