Skip to content

Shapeup-Pure-V5-task #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 1, 2021
Merged
16 changes: 5 additions & 11 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
version: 2
defaults: &defaults
docker:
- image: docker:18.06.0-ce-git
docker:
- image: circleci/python:2.7-stretch-browsers
install_dependency: &install_dependency
name: Installation of build and deployment dependencies.
command: |
apk update
apk add --no-cache bash
apk add --no-cache jq py-pip sudo curl
apk upgrade
pip install --upgrade pip
sudo apt install jq
sudo pip install awscli --upgrade
sudo curl -o /usr/local/bin/ecs-cli https://s3.amazonaws.com/amazon-ecs-cli/ecs-cli-linux-amd64-latest
sudo pip install docker-compose
sudo curl -o /usr/local/bin/ecs-cli https://s3.amazonaws.com/amazon-ecs-cli/ecs-cli-linux-amd64-latest
sudo chmod +x /usr/local/bin/ecs-cli

install_deploysuite: &install_deploysuite
Expand All @@ -22,7 +18,6 @@ install_deploysuite: &install_deploysuite
cp ./../buildscript/master_deploy.sh .
cp ./../buildscript/buildenv.sh .
cp ./../buildscript/awsconfiguration.sh .

run_build: &run_build
name: Installation of build dependencies.
command: ./build.sh
Expand Down Expand Up @@ -65,7 +60,6 @@ jobs:
./buildenv.sh -e PROD -b submission-processor-es_deployvar
source buildenvvar
./master_deploy.sh -d ECS -e PROD -t latest -s prod-global-appvar,submission-processor-es_appvar -i submission-processor-es

workflows:
version: 2
build:
Expand All @@ -80,4 +74,4 @@ workflows:
context : org-global
filters:
branches:
only: master
only: master
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,4 @@ npm run view-data a12a4180-65aa-42ec-a945-5fd21dec0501

```
{ "topic":"submission.notification.delete", "originator":"submission-api", "timestamp":"2018-08-06T15:46:05.575Z", "mime-type":"application/json", "payload":{ "resource":"review", "id": "d34d4180-65aa-42ec-a945-5fd21dec0503" } }
```
```
16 changes: 14 additions & 2 deletions src/services/ProcessorService.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ function * getESData (id) {
* @param {Object} message the message
*/
function * create (message) {
if (message.payload.resource === 'submission') {
message.payload.challengeId = message.payload.v5ChallengeId
delete message.payload.v5ChallengeId
}

yield client.create({
index: config.get('esConfig.ES_INDEX'),
type: config.get('esConfig.ES_TYPE'),
Expand All @@ -53,8 +58,8 @@ function * create (message) {
const submission = yield getESData(message.payload.submissionId)
let reviewSummationArr = []
reviewSummationArr.push(_.omit(message.payload, ['resource']))
if (submission.reviewSummationArr) {
reviewSummationArr = reviewSummationArr.concat(submission.review)
if (submission.reviewSummation) {
reviewSummationArr = reviewSummationArr.concat(submission.reviewSummation)
}
yield client.update({
index: config.get('esConfig.ES_INDEX'),
Expand Down Expand Up @@ -83,6 +88,13 @@ create.schema = {
* @param {Object} message the message
*/
function * update (message) {
if (message.payload.resource === 'submission') {
const legacyChallengeId = message.payload.challengeId
message.payload.challengeId = message.payload.v5ChallengeId
message.payload.legacyChallengeId = legacyChallengeId
delete message.payload.v5ChallengeId
}

yield client.update({
index: config.get('esConfig.ES_INDEX'),
type: config.get('esConfig.ES_TYPE'),
Expand Down