Review Summation on a resource becomes null

[callmekatootie]

From @cwdcwd via Slack:

I think we have a small bug here:

submission-processor-es/src/services/ProcessorService.js

Line 148 in 6681046

body: { doc: {reviewSummation: submission.reviewSummation} }

in the event of a delete on a reviewSummation that submission.reviewSummation can sometimes be null if all the summations are deleted. That puts a null in on that field instead of removing it entirely. This later gets concatenated with new reviewSummations.
I think we should null-check and then put and an empty array in if we can’t easily remove that field entirely.

[callmekatootie]

My analysis:

• _.remove() function will set it to an empty array, if the only element in the array is removed. Reference
• Assuming this still fails for some reason, and we do get null as the value, then we have a check at the time of review summation creation, where we verify that the submission payload already has the review summation array in it. In the event it is null, it does not get used. Reference

Basically, @cwdcwd the scenario that you have described cannot occur. Perhaps the issue you are facing is something else? 🤔

[cwdcwd]

I could be totally wrong. we did come up with at least 3 submission records that had a null in the first element of the array and then a reviewSummation and not all the other reviewSummations that were associated. so perhaps then it's an issue w/ the db fetch of the reviewSummation itself?

[callmekatootie]

@cwdcwd Could I proceed to merge this one into develop: #12

[callmekatootie]

Current Status: Made a fix as seen in the associated PR. Unsure if that is the cause of the issue reported. As of now this ticket is on hold and we hibernate it until we encounter the issue again

[drasticdpk]

@callmekatootie , please guide us if it can be verify if from UI.

[callmekatootie]

I am not sure about that - the discussion was only about the code and it sounded like somebody queried the submission api and observed null records in review summation...