Fix unit tests #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed method expectObj() which is used to assert objects. Before it always return true for any passed values.
The reason for that was that "_.pick(obj1, _.identity)" returns an empty object {} for any obj1.
This test failed after the fixing of expectObj() method.
This issue become visible after fixing the expectObj() method. The thing here is that when we use .empty(null) in Joi then if property is passed as "null" it's stripped from the object. As a result, we pass an object with "null" value, but we are trying to save in ES the object without value. This leads to the unit test fails, as saved value doesn't match the object which has been send in the message.
|
Good catch @maxceem about the passing tests. If I understand correctly, the comparison helper method was failing when any of the passed arguments as undefined and causing the tests to be passed? |
The helper method always returned "true" i. e. test always pass no matter what data we pass to this method:
So for two different objects, it also returned true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue so all the unit tests always passed.
This issue was fixed. After that, some issues become visible in existent unit tests, so they were fixed.