TCA-1077 free promo #536
Merged
TCA-1077 free promo #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testflyjets
reviewed
Feb 24, 2023
vas3a
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
@kkartunov can you use either svg or css gradients for the yellow/orange backgrounds? 66KB is pretty high for this. (see issues raised by QA & glenn that the BG for the enrolled modal which was 50KB was loading slowly)
Otherwise, looks good to me
@testflyjets yeah, that is my general approach. In this cas tho' there are some figures in that gradient, less visible but they are there, which I am tying to have as per design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements free promo, banner, details and enrollment pages.