Skip to content

TCA-870-cert-generation -> TCA-792_tc-certifications-epic #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 27, 2023

Conversation

kkartunov
Copy link
Collaborator

PR for code review to push upsteream the base tca certificate views.
WIP, more to come, this is just init stuff...
https://topcoder.atlassian.net/browse/TCA-870

Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To iterate. I'm not ok with the copy/pasting of course-certificate into tca-certificate.

I understand the concern but the options should be:

  • implement the routing and placeholder pages and wait for UI/UX before doing the actual implementation
  • move functionality and reuse components so we have the code in a single place instead of 2 copies of the exact same code (that will have slight differences eventually).

@kkartunov
Copy link
Collaborator Author

To iterate. I'm not ok with the copy/pasting of course-certificate into tca-certificate.

I understand the concern but the options should be:

  • implement the routing and placeholder pages and wait for UI/UX before doing the actual implementation
  • move functionality and reuse components so we have the code in a single place instead of 2 copies of the exact same code (that will have slight differences eventually).

@vas3a

  • PR implements the routing and placeholder pages.
  • moved functionality and made use of resue components.
  • when we have the final sertificate UI/UX we will refine the code base for even more reuse.

@kkartunov kkartunov merged commit 94628e3 into TCA-792_tc-certifications-epic Jan 27, 2023
@kkartunov kkartunov deleted the TCA-870-cert-generation branch February 17, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants