-
Notifications
You must be signed in to change notification settings - Fork 13
TCA-764 certification details ->TCA-792 #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCA-764 certification details ->TCA-792 #469
Conversation
Access to certification progress tracking features | ||
</li> | ||
<li> | ||
Unique certification certificate, that is uniquely displayed on your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure what "...that is uniquely displayed on your..." means -- can we confirm this copy with Glenn?
</li> | ||
</ul> | ||
`, | ||
title: 'Wait… aren’t the courses for free already? What exactly am I paying for?', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...aren't the courses for free already?" We should remove "for" from that phrase.
title: 'Wait… aren’t the courses for free already? What exactly am I paying for?', | ||
}, | ||
{ | ||
description: ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of FAQ text essentially duplicates the one above -- is this intentional? Seems that we've copy-pasted the same information in each block.
}, | ||
{ | ||
description: ` | ||
Topcoder is continuously looking for the best content to fill our certifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is different from the other items here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FAQs seem to contain the same boilerplate text.
import { ReactComponent as Icon } from './icon-level-3.svg' | ||
import styles from './LearnLevelIcon.module.scss' | ||
|
||
interface LearnLevelIconProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we here account for the icon type as well?
Adding property to control the icon type is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -35,36 +35,105 @@ export function useGetAllTCACertifications( | |||
} | |||
} | |||
|
|||
export function useGetCACertification( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to useGetTCACertification
…, update content texts
https://topcoder.atlassian.net/browse/TCA-764
https://topcoder.atlassian.net/browse/TCA-767
Implements certification details page + mobile.
Note: certification progress will be implemented in a separate ticket.