Skip to content

TCA-764 certification details ->TCA-792 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 23, 2023

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Jan 20, 2023

https://topcoder.atlassian.net/browse/TCA-764
https://topcoder.atlassian.net/browse/TCA-767

Implements certification details page + mobile.

Note: certification progress will be implemented in a separate ticket.

@vas3a vas3a self-assigned this Jan 20, 2023
Access to certification progress tracking features
</li>
<li>
Unique certification certificate, that is uniquely displayed on your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure what "...that is uniquely displayed on your..." means -- can we confirm this copy with Glenn?

</li>
</ul>
`,
title: 'Wait… aren’t the courses for free already? What exactly am I paying for?',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...aren't the courses for free already?" We should remove "for" from that phrase.

title: 'Wait… aren’t the courses for free already? What exactly am I paying for?',
},
{
description: `
Copy link
Contributor

@testflyjets testflyjets Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of FAQ text essentially duplicates the one above -- is this intentional? Seems that we've copy-pasted the same information in each block.

},
{
description: `
Topcoder is continuously looking for the best content to fill our certifications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is different from the other items here.

Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FAQs seem to contain the same boilerplate text.

import { ReactComponent as Icon } from './icon-level-3.svg'
import styles from './LearnLevelIcon.module.scss'

interface LearnLevelIconProps {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we here account for the icon type as well?
Adding property to control the icon type is needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component only refers to one single icon (which has 3 levels)
image

It will not support other icon types.

@@ -35,36 +35,105 @@ export function useGetAllTCACertifications(
}
}

export function useGetCACertification(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to useGetTCACertification

@vas3a vas3a merged commit 1c83cdc into TCA-792_tc-certifications-epic Jan 23, 2023
@vas3a vas3a deleted the TCA-764_certification_details branch January 23, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants