Skip to content

TCA-852 Check for Dice -> TCA-851_wipro-mfa #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 23, 2022

Conversation

brooketopcoder
Copy link
Contributor

@brooketopcoder brooketopcoder commented Dec 23, 2022

This PR adds all the code necessary to prevent wipro users w/out dice enabled from accessing any TCA lesson.

The next PR will add the modal to explain why.

I also snuck in a bug fix for the footer not loading for me locally. It works correctly in dev, so I assume it's just a timing thing.

Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean implementation!

@brooketopcoder brooketopcoder merged commit c0f4b7b into TCA-851_wipro-mfa Dec 23, 2022
@brooketopcoder brooketopcoder deleted the TCA-852_dice-check branch December 23, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants