Skip to content

TCA-796 fcc last lesson callback -> dev #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Dec 8, 2022

https://topcoder.atlassian.net/browse/TCA-796

Multiple issues found in the same area, while testing TCA-796:

  • uses progress.status to check for certification completion. If completed, show certificate completed screen. This is minor - because if this error fails, there's another useEffect hook that will force the view. This is to ensure faster redirect
  • fixes an issue where userCertificationProgress.ready wasn't boolean
  • debounces the events from FCC re lesson completed & last lesson. This will prevent multiple simultaneous calls to the api
  • When user starts a new course, call swr.mutate with the new course progress object. This allows for the FCC view to already have the data. If we don't do this , the user will not be redirected to FCC, but instead they'll have to click "resume" after they accept the policy.

@vas3a vas3a self-assigned this Dec 8, 2022
Copy link
Contributor

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vas3a vas3a merged commit 83f8a8d into dev Dec 9, 2022
@vas3a vas3a deleted the TCA-796_fcc-last-lesson-callback branch December 9, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants