TCA-790 Delay survey if the cert is completed -> dev #432
Conversation
| // the cert is also completed, which redirects the user to the cert page. | ||
| // So the survey needs to be delayed so that it appears on the completed | ||
| // cert page instead of the current lesson. | ||
| if (progress.certificationProgressPercentage === 100) { |
There was a problem hiding this comment.
I think we want to check the status == 'completed' or that the completedDate is not null instead of checking the actual percentage due to the occasional course info changes we get from FCC.
There was a problem hiding this comment.
@testflyjets right! I didn't think of that!
There was a problem hiding this comment.
@testflyjets @vas3a The status that comes back from the lesson completion is still in-progress. The status doesn't get changed to complete and the completedDate doesn't get set until a subsequent call.
I can move all of this logic to that other call if this data isn't stable.
There was a problem hiding this comment.
As we discussed, this is fine, just update the check to be >= 100 to account for the FCC lesson count discrepancies.
There was a problem hiding this comment.
Check with @vas3a on how best to check for certification completed.
… actually be more than 100% when data isn't in sync w/FCC. #time 15m
https://topcoder.atlassian.net/browse/TCA-526
This PR adds a delay to the survey trigger if the completed module also completes the certification.