PROD-3234 Add Spinner while Header Loads -> PROD-3115_uni-nav #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the loading spinner until the header is ready. It adds the url to the tool landing page. #time 2h
testflyjets
reviewed
Nov 21, 2022
| import { | ||
| authUrlLogin, | ||
| authUrlLogout, | ||
| authUrlSignup, | ||
| LoadingSpinner, |
There was a problem hiding this comment.
Is every tool and app that implements UniNav going to need to do this?
There was a problem hiding this comment.
@testflyjets every tool will need to handle the authentication part (login/logout/sign up, and "set user")
testflyjets
approved these changes
Nov 21, 2022
vas3a
reviewed
Nov 21, 2022
| @@ -55,6 +56,8 @@ const Header: FC = () => { | |||
| signOut() { window.location.href = authUrlLogout }, | |||
| signUp() { window.location.href = authUrlSignup() }, | |||
| toolName: activeToolName, | |||
| toolRoute: activeToolRoute, | |||
There was a problem hiding this comment.
@brooketopcoder you'll have to add an effect on activeToolName to "update" the uniNav.toolName with it.
Same thing with the user - init the nav without it, and update the tool nav when profileReady is true (this also solves the missing login/logout buttons).
There was a problem hiding this comment.
@vas3a yep--figured that out. I've done that in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.