Tca 499 eslint fix linting #410
Conversation
vas3a
commented
Nov 11, 2022
vas3a
commented
- fixes lint errors for src-ts/utils
- fixes part of the lint errors in src-ts/tools/learn
| @@ -24,7 +25,7 @@ export function useCourses(provider: string, certification?: string): CoursesPro | |||
| loading: false, | |||
| ready: false, | |||
| })) | |||
| return | |||
| return noop | |||
There was a problem hiding this comment.
I'm curious why use noop instead of undefined?
There was a problem hiding this comment.
Oh. sorry. The error confused me and I didn't look it up. I didn't realize I can just return undefined. Here's the error:
Arrow function expected no return value.eslint[consistent-return](https://eslint.org/docs/rules/consistent-return)
By consistent-return I immediately was thinking of "you need to return a function here as well"
src-ts/tools/learn/learn-lib/lesson-provider/lesson.provider.tsx
Outdated
Show resolved
Hide resolved
| @@ -7,6 +7,8 @@ import { UserCertificationUpdateProgressActions } from './user-certification-upd | |||
|
|
|||
| const certProgressPath: string = 'certification-progresses' | |||
|
|
|||
| type GenericDataObject = { [key: string]: string | GenericDataObject } | |||
There was a problem hiding this comment.
I like this! Maybe we should make this globally available? I am sure there are other places that would use this. It seems strange that TS doesn't provide something like this OTB.
| @@ -68,7 +70,7 @@ const Account: FC<{}> = () => { | |||
| <Button | |||
| label='edit name' | |||
| onClick={toggleEditName} | |||
| tabIndex={1} | |||
| tabIndex={-1} | |||
There was a problem hiding this comment.
These are explicitly set to 1 and 2 bc of the weirdness of the form in the modal. That's why I left this rule a warning instead of an error.
There was a problem hiding this comment.
I see. we should probably disable the rule for the file in this case, right? (as this is unavoidable and it will just keep warning otherwise)
TCA-499 eslint Add Line Breaks Before Chained Methods -> TCA-499_eslint
…der-platform/platform-ui into TCA-499_eslint_fix-linting
