Skip to content

TCA-645 Example Complex Lint Fixes -> TCA-499_eslint #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2022
Merged

TCA-645 Example Complex Lint Fixes -> TCA-499_eslint #403

merged 4 commits into from
Nov 9, 2022

Conversation

brooketopcoder
Copy link
Contributor

@brooketopcoder brooketopcoder commented Nov 8, 2022 •
edited
Loading

This commit gives examples for how to fix several lint issues:

  • dependencies in the wrong place in package.json
  • improved .scss type declaration
  • react/jsx-no-bind
  • react/destructuring-assignment
  • @typescript-eslint/no-explicit-any

And a couple more obvious ones.

@brooketopcoder brooketopcoder self-assigned this Nov 8, 2022
vas3a
vas3a reviewed Nov 8, 2022
View reviewed changes
vas3a
vas3a approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just that thought on resolving the react/jsx-no-bind rule.

@brooketopcoder
TCA-645 clean up
dd56bd7
@brooketopcoder
TCA-645 #comment This PR fixes a lint issue that i didn't understand …
3ce8286 
…how it worked and made the issue worse. Thanks Vasilica #time 15m
Base automatically changed from TCA-647_delete-prettier to TCA-499_eslint November 9, 2022 17:13
@brooketopcoder brooketopcoder merged commit b329c34 into TCA-499_eslint Nov 9, 2022
@brooketopcoder brooketopcoder deleted the TCA-645_example-fixes branch November 9, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vas3a vas3a vas3a approved these changes

@testflyjets testflyjets Awaiting requested review from testflyjets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooketopcoder @vas3a