Skip to content

TCA-299 - Review UI for javascript course #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Aug 12, 2022

TCA-299

  • update ui for old style courses (eg. JavaScript Algorithms and Data Structures) to match figma's old style editor.
  • update platform-ui/learn to fit the new layout for the course outline:
  • implemented style (step based):
    image
  • newly implemented style (lessons based):
    image

related PR: topcoder-platform/freeCodeCamp#44

Copy link
Contributor

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great--thanks for the quick work!

color: $black-20;

.icon {
width: 20px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is soooooooo nit-picky... can we use the icon size mixin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally! forgot about it! >_<

@vas3a vas3a merged commit 938cdf6 into dev Aug 15, 2022
@brooketopcoder brooketopcoder deleted the TCA-299_ui-for-js-course branch August 24, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants