PROD-2549 Add Course State to Course Cards -> dev #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser id; make function and variable names more explicit; lint fixes; add user's course state to the course cards; refactor progress block to use the same course state the cards use; #time 4h
testflyjets
approved these changes
Jul 22, 2022
vas3a
reviewed
Jul 25, 2022
vas3a
reviewed
Jul 25, 2022
vas3a
reviewed
Jul 25, 2022
vas3a
reviewed
Jul 25, 2022
src-ts/tools/learn/learn-lib/my-certifications-provider/my-certifications.provider.tsx
Outdated
Show resolved
Hide resolved
vas3a
reviewed
Jul 25, 2022
vas3a
reviewed
Jul 25, 2022
src-ts/tools/learn/learn-lib/my-certifications-provider/my-certification-progress.provider.tsx
Outdated
Show resolved
Hide resolved
vas3a
approved these changes
Jul 25, 2022
…for other users #time 1h
|
@vas3a I added the userId argument back and renamed everything User Certifications rather than My Certifications. I also renamed Certifications to All Certifications to be totally explicit. |
vas3a
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PROD-2549
This PR updates the /learn landing page so the progress block on the top right of the page matches the course cards at the bottom of the page.
Also, because this is the first UI work I've done in the Learn tool, I did a small bit of refactor to make some of the variable names, etc more clear to me and to simplify some of the methods.
Oh, and also some formatting mods to make it easier for me to read.