Skip to content

PROD-2468 Timeline -> PROD-2321 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 22, 2022
Merged

PROD-2468 Timeline -> PROD-2321 #209

merged 6 commits into from
Jul 22, 2022

Conversation

mmattlin
Copy link

What's in this PR?

  • Updates the timeline for a challenge based on the package the user selects. The only phase that differs is the Submission phase: Standard=24hrs, Advanced=48hrs, Premium=72hrs
  • Also fixes the route for the review page, which was previously directing other intake types to the new review page

Screenshots

(from Work Manager of submitted challenges)

Standard:
image

Advanced:
image

Premium:
image

@mmattlin mmattlin self-assigned this Jul 22, 2022
@mmattlin mmattlin requested a review from hentrymartin July 22, 2022 19:04
dave-armstrong-topcoder
dave-armstrong-topcoder approved these changes Jul 22, 2022
View reviewed changes
Copy link

@dave-armstrong-topcoder dave-armstrong-topcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thread we had about the phaseIds, all else looks good.

@mmattlin mmattlin merged commit 938ce51 into PROD-2321_bug-hunt-intake-form Jul 22, 2022
@mmattlin mmattlin deleted the PROD-2568_timeline branch July 22, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-armstrong-topcoder dave-armstrong-topcoder dave-armstrong-topcoder approved these changes

@hentrymartin hentrymartin Awaiting requested review from hentrymartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmattlin @dave-armstrong-topcoder