Skip to content

Bug hunt - Set current step #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dave-armstrong-topcoder

What's in this PR?

  • Set currentStep when saving or submitting from info page
  • removing forced redirects

Rationale for removing the forced redirects:

I started thinking more about these redirects because they started to feel like too much control once I had them working. (There also were tech barriers with isLoggedIn being async, with the initial render showing false even when you are logged in. This leads to the useEffect on 1st render to use the stale 'false' value, so we'd need solve the data load differently to get an accurate value to know whether to direct to the login vs. review page)

In any case, Forcing a redirect to the last page the user was on will drive us to manage that data in the challenge on every page flow, including back buttons, edits, and following breadcrumbs. This may not be wise, as a user might simply navigate in one of those ways without intending to take the form out of review. So we would be putting in more complexity to tightly control the navigation when I don't know that we've proven the need.

This PR does still allow the user to maintain that control - if they want to edit and leave it out of review, 'Save for Later' does so.

I'd prefer for the initial form delivery to simply log the currentStep when they save, and let Product/QA/UAT come back to us with a request for tighter control if needed.

@dave-armstrong-topcoder dave-armstrong-topcoder merged commit 9fa0448 into PROD-2321_bug-hunt-intake-form Jul 22, 2022
@dave-armstrong-topcoder dave-armstrong-topcoder deleted the bug-hunt-set-currentStep branch July 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants