Skip to content

PROD-2420 styling fixes -> dev #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2022
Merged

PROD-2420 styling fixes -> dev #149

merged 2 commits into from
Jul 7, 2022

Conversation

mmattlin
Copy link

@mmattlin mmattlin commented Jul 7, 2022

What's in this PR?

Fixes styling issues throughout the app. In some cases where the React component takes in the name of a css class as a prop, it had been replaced with className instead of passing it in as a prop, which overwrote the component's default styling.

Fixes include:

  1. Bottom of textbox input was not being displayed correctly
  2. Textarea text was using the wrong font and wrong height
  3. Missing top margin on form section headings
  4. Extra spacing between the pricing banner and "What will I get?" box in Review page
  5. Incorrect styling for Start Work heading

Screenshots

Before:
image

image

image

After:
image

image

image

@mmattlin mmattlin self-assigned this Jul 7, 2022
@mmattlin mmattlin merged commit dcb9106 into dev Jul 7, 2022
@mmattlin mmattlin deleted the PROD-2420_field-styling branch July 7, 2022 08:21
@brooketopcoder brooketopcoder restored the PROD-2420_field-styling branch July 7, 2022 14:47
Copy link
Contributor

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmattlin this looks good! Thanks for being so thorough. I just made one tiny comment and addressed it in this PR. https://github.com/topcoder-platform/platform-ui/pull/153/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants