feat(PM-580): added assign action to applications list #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...src/pages/copilot-opportunity-details/tabs/copilot-applications/CopilotApplicationAction.tsx
Show resolved
Hide resolved
...src/pages/copilot-opportunity-details/tabs/copilot-applications/CopilotApplicationAction.tsx
Show resolved
Hide resolved
...src/pages/copilot-opportunity-details/tabs/copilot-applications/CopilotApplicationAction.tsx
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/tabs/copilot-applications/CopilotApplications.tsx
Show resolved
Hide resolved
.../copilots/src/pages/copilot-opportunity-details/tabs/copilot-applications/styles.module.scss
Show resolved
Hide resolved
| @@ -105,6 +105,21 @@ export const applyCopilotOpportunity = async (opportunityId: number, request?: { | |||
| return xhrPostAsync(url, request, {}) | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
The function name assignCopilotOpportunity is similar to applyCopilotOpportunity. Consider renaming for clarity, especially if both functions are used in similar contexts.
...src/pages/copilot-opportunity-details/tabs/copilot-applications/CopilotApplicationAction.tsx
Show resolved
Hide resolved
| export interface CopilotApplication { | ||
| id: number, | ||
| notes?: string, | ||
| createdAt: Date, | ||
| opportunityId: string, | ||
| handle?: string, | ||
| userId: number, | ||
| status: CopilotApplicationStatus, |
There was a problem hiding this comment.
Consider ensuring that CopilotApplicationStatus is properly defined and imported in this file to avoid any potential issues with type resolution.
| /** | ||
| * apply copilot opportunity | ||
| * @param opportunityId | ||
| * @param applicationId |
There was a problem hiding this comment.
The parameter name in the function signature should be updated to match the JSDoc comment. If the parameter is indeed applicationId, ensure the function signature reflects this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-580
What's in this PR?
Screenshots