Skip to content

PM-589 Improve skills UI #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

PM-589 Improve skills UI #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8043b02
PM-589 Improve skills UI
Apr 25, 2025
a34c0bd
bot review fixes
Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions src/apps/copilots/src/pages/copilot-opportunity-list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,29 @@ const tableColumns: TableColumn<CopilotOpportunity>[] = [
isSortable: false,
label: 'Skills Required',
propertyName: 'skills',
renderer: (copilotOpportunity: CopilotOpportunity) => (
<div className={styles.skillsContainer}>
{copilotOpportunity.skills.map((skill: any) => (
<div key={skill.id} className={styles.skillPill}>
{skill.name}
</div>
))}
</div>
),
renderer: (copilotOpportunity: CopilotOpportunity) => {
const visibleSkills = copilotOpportunity.skills.slice(0, 3)
const remainingSkills = copilotOpportunity.skills.slice(3)
return (
<div className={styles.skillsContainer}>
{visibleSkills.map((skill: { id: string | number; name: string }) => (
<div key={skill.id} className={styles.skillPill}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider specifying the type for skill in the map function to improve type safety and readability.

{skill.name}
</div>
))}
{remainingSkills.length > 0 && (
<div
className={styles.skillPill}
title={remainingSkills.map(skill => skill.name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Array.prototype.join without a separator defaults to a comma, which is fine here, but it might be clearer to explicitly specify the separator as ', ' for readability.

.join(', ')}
>
+
{remainingSkills.length}
</div>
)}
</div>
)
},
type: 'element',
},
{
Expand Down
4 changes: 2 additions & 2 deletions src/apps/copilots/src/pages/copilot-opportunity-list/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
}

.skillPill {
background-color: #aaaaaa;
background-color: #d6d6d6;
color: #333;
padding: 4px 8px;
border-radius: 10px;
white-space: break-spaces;
font-size: 14px;
font-size: 11px;
}

.status {
Expand Down