PM-1064 Request Copilot button on opportunity feed #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -107,9 +112,15 @@ const CopilotOpportunityList: FC<{}> = () => { | |||
|
|
|||
| const opportunitiesLoading = isValidating | |||
|
|
|||
| const addNewRequestButton: ButtonProps = { | |||
| label: 'New Copilot Request', | |||
| onClick: () => navigate(copilotRoutesMap.CopilotRequestForm), | |||
There was a problem hiding this comment.
Consider adding error handling for the navigate function to handle cases where the navigation might fail.
kkartunov
requested changes
Apr 28, 2025
| @@ -88,6 +90,9 @@ const tableColumns: TableColumn<CopilotOpportunity>[] = [ | |||
| const CopilotOpportunityList: FC<{}> = () => { | |||
| const navigate = useNavigate() | |||
|
|
|||
| const { profile }: ProfileContextData = useContext(profileContext) | |||
| const isAdmin: boolean = useMemo(() => !!profile?.roles?.includes(UserRole.tcaAdmin), [profile]) | |||
There was a problem hiding this comment.
@himaniraghav3 can we please extend this to PM role to ensure PMs can use the functionality as well?
| @@ -88,6 +90,12 @@ const tableColumns: TableColumn<CopilotOpportunity>[] = [ | |||
| const CopilotOpportunityList: FC<{}> = () => { | |||
| const navigate = useNavigate() | |||
|
|
|||
| const { profile }: ProfileContextData = useContext(profileContext) | |||
| const isAdminOrPM: boolean = useMemo( | |||
| () => !!profile?.roles?.some(role => role === UserRole.tcaAdmin || role === UserRole.projectManager), | |||
There was a problem hiding this comment.
Consider using includes instead of some for checking roles if the list of roles is small and fixed, as it can be more readable and straightforward.
kkartunov
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1064
What's in this PR?
Admin can see a "New Copilot Request" button on the opportunity listing page which takes them to the form.