Skip to content

added functionalities to add and remove the members in bulk #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

bountyC0d3r
Copy link
Collaborator

No description provided.

@LieutenantRoger
Copy link
Contributor

Hi @bountyC0d3r

The implementation seems reused the original add/remove members method for bulk operations, right ? I think the implementation will work.

I have two thoughts on the implementation

  1. Is the new endpoint not restricting the member items ? It might be leads the caller to timeout if the caller passed in a very long list of the member items

  2. Since it used the original method for add/delete, so each item will start a neo4j transaction, which might not be efficient and occupy too many neo4j connections. Maybe can we explore some alternative way to do the bulk in one transaction of neo4j ?

Thanks

@bountyC0d3r
Copy link
Collaborator Author

@LieutenantRoger I agree with you on the 2 points you have mentioned, and here are my thoughts on them:

  1. Limit on number of requests we need to put in the group manager based on the performance of the API
  2. Yes, we need to implement the bulk add/remove using the single query; which is the target for the next phase, where I'm going to change the query formats to support the v4 of the neo4j db; this will be the part of overall optimisation

@LieutenantRoger
Copy link
Contributor

I seems to be able to merge the pull request for this repository, let me know if you need me to do the merge or yourself can do this when you need to merge, thanks

@rakibansary rakibansary self-requested a review September 3, 2022 18:48
@bountyC0d3r
Copy link
Collaborator Author

Merging this with the develop

@bountyC0d3r bountyC0d3r merged commit 5e42e97 into develop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants