[$40] Project Groups API | Searching groups as a non admin user fails

[callmekatootie]

When searching groups as a non admin user, we get the following error:

{
    "message": "\"memberId\" must be a string"
}

It seems we are not converting the memberId which is a Number to String before passing to the service and the validator complains

[callmekatootie]

Similar conversion issue observed here. The equality is never true due to the wrong data types.

[GoodFaithParadigm8]

There is a note as to where the validation occurs for what is described as an "optionalID":

groups-api/src/services/GroupService.js

Line 156 in 646510a

memberId: Joi.optionalId(), // defined in app-bootstrap

in app-bootstrap:

groups-api/app-bootstrap.js

Line 7 in 646510a

Joi.optionalId = () => Joi.string()

I changed the validation from string to number and retested the endpoint, however there is no connection to a hosted database and I have no local database with data to make a successful call.

This is the config:
https://github.com/topcoder-platform/groups-api/blob/develop/config/default.js

I require a hydrated test database or data to hydrate a local database to test this any further.

[GoodFaithParadigm8]

optionalId is used for both memberId and universalUID

memberId seems to be a number and universalUID a string, so another way to handle the joi validation for optionalID is Joi.alternatives().try(Joi.number(), Joi.string()); to satisfy the validation for both identifier types.

[callmekatootie]

Contest https://www.topcoder.com/challenges/30155058 has been created for this ticket.

This is an automated message for callmekatootie via Topcoder X

[callmekatootie]

@GoodFaithParadigm8, please sign-up with Topcoder X tool

This is an automated message for callmekatootie via Topcoder X

[callmekatootie]

@GoodFaithParadigm8 Could you kindly register here - https://x.topcoder.com/api/v1/github/teams/registration/d8e0ccbc-7dec-43ce-b974-c295db0c10fe-1606816400259 - so that I can pay you $40 towards the efforts in this ticket. Your Pull Request was accepted.

[lakshmiathreya]

@callmekatootie - need clarification reg the testing for this - I notice Groups search works fine in Prod currently - checked via Copilot - non Admin user in Work manager. Can you let me know the specific case where Search is failing currently in Prod?