Skip to content

TCA-480 - replace fcc links located in the lesson content #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Sep 28, 2022

https://topcoder.atlassian.net/browse/TCA-480

Replace the FCC courses links that are located in the lesson content with links pointed to platform-ui.

Example lesson that has a link to another course:

https://platform-ui.topcoder-dev.com/learn/freeCodeCamp/quality-assurance/quality-assurance-and-testing-with-chai/use-assert-isok-and-assert-isnotok

image

Copy link

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changed links all point to topcoder.com -- how's this going to work in the dev environment?

@vas3a
Copy link
Collaborator Author

vas3a commented Sep 28, 2022

@testflyjets it will just redirect to the prod urls. Not sure if we can modify the urls inside the lesson content to be environment aware, should this be a concern?

@testflyjets
Copy link

@testflyjets it will just redirect to the prod urls. Not sure if we can modify the urls inside the lesson content to be environment aware, should this be a concern?

If the user doesn't have to follow the link to complete the challenge then it most likely won't matter that links in dev point to prod. All good.

@vas3a
Copy link
Collaborator Author

vas3a commented Sep 28, 2022

Yup. these are just suggestions, they don't matter for the challenge itself.

@vas3a vas3a merged commit 5b15282 into dev Sep 29, 2022
@vas3a vas3a deleted the TCA-480_open-course-link-in-new-tab branch September 29, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants