Skip to content

TCA-443 - persist layout selection in localstorage #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Sep 21, 2022

https://topcoder.atlassian.net/browse/TCA-443

Persist layout changes (pane selections) in Local Storage.

image

Copy link

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I wonder if it would make sense to open a PR w/the original forked branch to see if FCC wants to integrate it into their own code.

@vas3a
Copy link
Collaborator Author

vas3a commented Sep 21, 2022

@brooketopcoder I'll need to fork the original branch, cherry-pick these changes and do a PR. I don't see any reason not to do it (might have to look another look at their coding guide, but shouldn't be a big deal).

@vas3a vas3a merged commit 7de171c into dev Sep 21, 2022
@vas3a vas3a deleted the TCA-443_persist-layout-in-localstorage branch October 5, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants