Remove Mongo URL logging > prod #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me-fix TCA-354 - fix handler for external urls when url is fcc lesson
Removes logging of Mongo URL
…v branch #time 5m
… challenge #time 15m
TCA-397 lint issues -> dev
TCA-385 forbidden error logging -> dev
| @@ -258,16 +258,24 @@ export function isValidChallengeCompletion(req, res, next) { | |||
| message: 'That does not appear to be a valid challenge submission.' | |||
| }; | |||
|
|
|||
| console.debug('console.debug'); | |||
There was a problem hiding this comment.
Should we hold off on deploying this logging to prod? It was meant to be temporary, but I was never able to test it bc of the deployment issue.
Maybe we can merge the branch that removes the mongo db logging directly into master instead of going through dev?
I am also seeing some other changes not related to the mongo db logging in this PR.
There was a problem hiding this comment.
I'm fine if we want to merge just my branch into master.
There was a problem hiding this comment.
@testflyjets Cool--I'd be more comfortable if we did that.
TCA-397 Lint Fix -> dev
… a challenge #time 10m
TCA-385 Adds more logging -> dev
TCA-385 More logging -> dev
TCA-385 remove extra logging -> dev
…project-layout TCA-425 - Update backend projects to advance to next lesson without c…
TCA-385 clean up logging -> dev
|
I am closing this PR bc the 1-line removal of the mongo logging was done in a PR to master directly: #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR