Skip to content

TCA-373 Support FCC Video Links -> dev #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2022
Merged

TCA-373 Support FCC Video Links -> dev #54

merged 3 commits into from
Aug 31, 2022

Conversation

brooketopcoder
Copy link

https://topcoder.atlassian.net/browse/TCA-373

This PR updates the external link handler so FCC URLs that aren't lessons (and therefore not available on the TC site) open correctly.

NOTE: The dead links described in the ticket are not addressed in this branch. We will need to determine the best way to update course content.

@brooketopcoder brooketopcoder self-assigned this Aug 26, 2022
vas3a
vas3a approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@brooketopcoder brooketopcoder merged commit e5e79d9 into dev Aug 31, 2022
@brooketopcoder brooketopcoder deleted the TCA-373_handle-videos branch August 31, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vas3a vas3a vas3a approved these changes

@testflyjets testflyjets Awaiting requested review from testflyjets

Assignees

@brooketopcoder brooketopcoder

Labels
platform: client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brooketopcoder @vas3a @testflyjets