Skip to content

TCA-355 Open External Links in New Window -> dev #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

brooketopcoder
Copy link

@brooketopcoder brooketopcoder commented Aug 24, 2022

https://topcoder.atlassian.net/browse/TCA-355

This PR opens all external links in the FCC app in a new window.

Have I mentioned how much prettier sucks? It has rules that make code much more difficult to read and which cannot be overridden: prettier/prettier#4870

… are redirected to a new window. Also removing prettier bc it sucks. #time 4h
@brooketopcoder brooketopcoder self-assigned this Aug 24, 2022
Copy link

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Prettier is a PITA!

@brooketopcoder brooketopcoder merged commit c1587f8 into dev Aug 24, 2022
@brooketopcoder brooketopcoder deleted the TCA-355_external-links branch August 24, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants