migrate tests for 'build-a-25-5-clock' project to use FCC instead of … #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vas3a
reviewed
Aug 15, 2022
There was a problem hiding this comment.
I did an overall code review and checked to see if the behavior in the FCC editor is as expected (tests are passing and matching criteria according to test description).
There are some console errors but the same behavior is found in the existing "migrated" courses.
Otherwise looks good to me!
testflyjets
approved these changes
Aug 15, 2022
brooketopcoder
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…codepen
Checklist:
Update index.md)mainbranch of freeCodeCamp.Closes #XXXXX