Skip to content

Issues-483, Issues-484, Issues-535: Added validation of comment lengt… #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Issues-483, Issues-484, Issues-535: Added validation of comment lengt… #536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion vanilla/applications/vanilla/js/discussion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ jQuery(document).ready(function($) {
// Hide it if they leave the area without typing
$('div.CommentForm textarea').blur(function(ev) {
var Comment = $(ev.target).val();
var textArea = $(ev.target);
if (!Comment || Comment == '')
$('a.Cancel').hide();
$(textArea).closest('a.Cancel').hide();
});

// Reveal the textarea and hide previews.
Expand All @@ -33,6 +34,7 @@ jQuery(document).ready(function($) {
var textbox = $(frm).find('textarea');
var inpCommentID = $(frm).find('input:hidden[name$=CommentID]');
var inpDraftID = $(frm).find('input:hidden[name$=DraftID]');
var maxCommentLength = $(frm).find('input:hidden[name$=MaxCommentLength]');
var type = 'Post';
var preview = $(btn).hasClass('PreviewButton');
var defaultValues = [
Expand All @@ -48,6 +50,34 @@ jQuery(document).ready(function($) {
return false;
}
}

var editorContainer = $(frm).find('.EasyMDEContainer');
var messageContainer = $(frm).find('.editor-statusbar .message');

var currentVal = $(textbox).val();
if(defaultValues.includes(currentVal) || currentVal.trim().length == 0) {
$(editorContainer).addClass('error');
$(messageContainer).text('Cannot post an empty message');
$(frm).find(':submit').attr('disabled', 'disabled');
$(frm).find('.Buttons a.Button:not(.Cancel)').addClass('Disabled');
return false;
}


if(currentVal.length > maxCommentLength.val()) {
$(editorContainer).addClass('error');
var count = currentVal.length - maxCommentLength.val();
$(messageContainer).text('Comment is '+ count +' characters too long');
$(frm).find(':submit').attr('disabled', 'disabled');
$(frm).find('.Buttons a.Button:not(.Cancel)').addClass('Disabled');
return false;
}

$(editorContainer).removeClass('error');
$(messageContainer).text('');
$(frm).find(':submit').removeAttr("disabled");
$(frm).find('.Buttons a.Button').removeClass('Disabled');

var draft = $(btn).hasClass('DraftButton');
if (draft) {
var currentVal = $(textbox).val()
Expand Down