-
Notifications
You must be signed in to change notification settings - Fork 0
PLAT-2173 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hamidre13
wants to merge
2
commits into
main
Choose a base branch
from
feature/PLAT-2173
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,543
−18
Open
PLAT-2173 #1
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/usr/bin/env sh | ||
. "$(dirname -- "$0")/_/husky.sh" | ||
|
||
npx --no -- commitlint --edit "$1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
# Contributing | ||
|
||
As a contributor, here are the guidelines we would like you to follow: | ||
|
||
- [Coding Rules](#markdown-header-coding-rules) | ||
- [Working with branches](#markdown-header-working-with-branches) | ||
- [Commit Message Guidelines](#markdown-header-commit=message-format) | ||
|
||
## Coding Rules | ||
|
||
TODO | ||
|
||
## Working with branches | ||
|
||
Remote branches must follow the following format: | ||
|
||
- fix/my-fix-name: for bugfixes/hotfixes | ||
- feature/my-feature-name: for features, refactoring, etc | ||
|
||
Branches name **must be in kebab-case and lower caps**. | ||
|
||
Please **keep the commit history of your branch clean**, with proper commit messages (see below). | ||
Use `git log` to review it, and if necessary `git rebase` to clean it. | ||
|
||
> See the [git docs](https://git-scm.com/docs/git-rebase#_interactive_mode) for more details. | ||
|
||
## Commit Message Format | ||
|
||
_This specification is inspired by [Angular commit message format](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-format)._ | ||
|
||
We have very precise rules over how our Git commit messages must be formatted. | ||
This format leads to **easier to read commit history**. | ||
|
||
Each commit message consists of a **header** and a **body** | ||
|
||
``` | ||
<header> | ||
<BLANK LINE> | ||
<body> | ||
``` | ||
|
||
The `header` is mandatory and must conform to the [Commit Message Header](#markdown-header-commit-message-header) format. | ||
|
||
The `body` is mandatory for all commits except for those of type "docs". | ||
When the body is present it must be at least 20 characters long and must conform to the [Commit Message Body](#markdown-header-commit-message-body) format. | ||
|
||
Any line of the commit message cannot be longer than 100 characters. | ||
|
||
### Commit Message Header | ||
|
||
``` | ||
<type>(<scope>): <short summary> | ||
│ | │ | ||
│ | └─⫸ Summary in present tense. Not capitalized. No period at the end. | ||
| | | ||
| └─⫸ Commit Scope: domain-challenge|domain-resource|lib-logger|lib-common|lib-secrets | ||
| | ||
└─⫸ Commit Type: feat|fix|docs|chore|refactor|ci|test|perf|revert | ||
``` | ||
|
||
Both `<type>` and `<summary>` fields are mandatory. | ||
|
||
#### Type | ||
|
||
Must be one of the following: | ||
|
||
- **feat**: A new feature | ||
- **fix**: A bug fix | ||
- **docs**: Documentation (README, CONTRIBUTING and code documentation) | ||
- **chore**: Changes to the build process or auxiliary tools and libraries such as documentation generation | ||
- **refactor**: A code change that neither fixes a bug nor adds a feature | ||
- **ci**: Changes to our CI/CD configuration files and scripts | ||
- **test**: Adding missing tests or correcting existing tests | ||
- **perf**: A code change that improves performance | ||
- **revert**: Reverts a previous commit | ||
|
||
#### Summary | ||
|
||
Use the summary field to provide a succinct description of the change: | ||
|
||
- use the imperative, present tense: "change" not "changed" nor "changes" | ||
- don't capitalize the first letter | ||
- no dot (.) at the end | ||
|
||
### Commit Message Body | ||
|
||
Just as in the summary, use the imperative, present tense: "fix" not "fixed" nor "fixes". | ||
|
||
Explain the motivation for the change in the commit message body. This commit message should explain _why_ you are making the change. | ||
You can include a comparison of the previous behavior with the new behavior in order to illustrate the impact of the change. | ||
|
||
### Revert commits | ||
|
||
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. | ||
|
||
The content of the commit message body should contain: | ||
|
||
- information about the SHA of the commit being reverted in the following format: `This reverts commit <SHA>`, | ||
- a clear description of the reason for reverting the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module.exports = { | ||
extends: [ | ||
"@commitlint/config-conventional" | ||
], | ||
rules: { | ||
"type-enum": [ | ||
2, | ||
"always", | ||
[ | ||
"feat", | ||
"fix", | ||
"docs", | ||
"chore", | ||
"refactor", | ||
"ci", | ||
"test", | ||
"perf", | ||
"revert", | ||
], | ||
], | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.