Skip to content

Release v1.17.5 - hotfix: topgear challenges listing page not showing #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Release v1.17.5 - hotfix: topgear challenges listing page not showing #6549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
977428e
fix: topgear page not loading
rakibansary Jun 23, 2022
cd48712
fix: update test snapshots
rakibansary Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/shared/components/__snapshots__/Content.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ exports[`Matches shallow shapshot 1`] = `
<li>
<Link
replace={false}
to="/__community__/wipro"
to="/__community__/wipro/challenges"
>
TopGear (Wipro) community
</Link>
Expand Down
11 changes: 11 additions & 0 deletions src/server/services/communities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,17 @@ export async function getMetadata(communityId) {
if (metadata.groupIds) {
metadata.groupIds = await extendByChildGroups(metadata.groupIds);
}

// FIXME: This is a tempory patch to resolve "Backstage Error" that's showing up on Topgear
// app due to missing "Wipro All" authorized group
// Roll this back as soon as the root cause is fixed
// which is likely either in topcoder-react-lib that handles merging groups (https://github.com/topcoder-platform/topcoder-react-lib/blob/c637525211550bea283390e52490fce7f6dd44a8/src/services/groups.js#L107)
// or Groups Api
if (communityId === 'wipro') {
logger.info('Getting metadata for Topgear. Existing Authorized Groups', JSON.stringify(metadata.authorizedGroupIds));
metadata.authorizedGroupIds = _.uniq(metadata.authorizedGroupIds.concat('b7f7c0f8-8ee8-409e-9e5c-33404983b635'));
logger.info('After adding "Wipro All" group', JSON.stringify(metadata.authorizedGroupIds));
}
getMetadata.cache[communityId] = { data: metadata, timestamp: now };
return _.cloneDeep(metadata);
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/Content/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ export default function Content() {
</Link>
</li>
<li>
<Link to="/__community__/wipro">
<Link to="/__community__/wipro/challenges">
TopGear (Wipro) community
</Link>
</li>
Expand Down