issue #5501 fix: member country is not displayed in settings #5591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use homeCountryCode or competitionCountryCode as displayed country in member settings page when country is not found in the basic_info traits
gets0ul
requested review from
ajefts,
luizrrodrigues and
sushilshinde
as code owners
luizrrodrigues
requested changes
Jun 29, 2021
There was a problem hiding this comment.
@gets0ul If try to edit any field will show error message in Country field:
https://i.gyazo.com/e9c82a736649ac24d292a15cb5fbe0f6.mp4
@gets0ul can you finish this today? |
|
@sushilshinde Yes, will update it ASAP |
update state when list of all countries for mapping has been received from back end.
|
@luizrrodrigues @sushilshinde Updated |
|
@gets0ul Thanks, checking. |
luizrrodrigues
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5501
use homeCountryCode or competitionCountryCode as displayed country in member settings page when country is not found in the basic_info traits