Skip to content

issue 2835 fix #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 25, 2019
Merged

issue 2835 fix #2945

merged 6 commits into from
Jul 25, 2019

Conversation

PrakashDurlabhji
Copy link
Contributor

No description provided.

@PrakashDurlabhji PrakashDurlabhji mentioned this pull request Jul 18, 2019
Closed
@anonymousjaggu
Copy link
Collaborator

Hi @PrakashDurlabhji
This is still reading as a link, you must add aria-label in parent anchor tag instead of span

@anonymousjaggu anonymousjaggu self-assigned this Jul 23, 2019
@PrakashDurlabhji
Copy link
Contributor Author

@anonymousjaggu added a tag instead of span, test case may fail, I will update it, but till then u can check taking pull. even i will do it

@PrakashDurlabhji
Copy link
Contributor Author

@anonymousjaggu PR updated

@anonymousjaggu
Copy link
Collaborator

@PrakashDurlabhji Please read the description carefully
image

You are making changes the wrong number of registrant you are doing a number of submission

@PrakashDurlabhji
Copy link
Contributor Author

@anonymousjaggu updating in few minutes

@PrakashDurlabhji
Copy link
Contributor Author

@anonymousjaggu PR updated

@anonymousjaggu
Copy link
Collaborator

@anonymousjaggu PR updated

OK MR looks fine now

@sushilshinde sushilshinde merged commit 5bbe06c into topcoder-platform:qa-accessibility Jul 25, 2019
sushilshinde added a commit that referenced this pull request Jul 28, 2019
@sushilshinde
Merge pull request #2945 from PrakashDurlabhji/issue_2835
6a0de3d 
issue 2835 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@sushilshinde sushilshinde Awaiting requested review from sushilshinde sushilshinde is a code owner

Assignees

@anonymousjaggu anonymousjaggu

Labels
Merged for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PrakashDurlabhji @anonymousjaggu @sushilshinde @veshu