Skip to content

Issue 2873 fix #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 28, 2019
Merged

Issue 2873 fix #2933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f516cc6
Update index.jsx
PrakashDurlabhji Jul 18, 2019
d3f91eb
fix
PrakashDurlabhji Jul 19, 2019
df5157c
test fix
PrakashDurlabhji Jul 19, 2019
6a90292
test fix
PrakashDurlabhji Jul 19, 2019
cec2bb4
Merge branch 'qa-accessibility' into issue_2873
PrakashDurlabhji Jul 24, 2019
8cc4614
Update .eslintrc
PrakashDurlabhji Jul 25, 2019
084f296
Update index.jsx
PrakashDurlabhji Jul 25, 2019
4907545
Update index.jsx
PrakashDurlabhji Jul 25, 2019
714ace5
Update index.jsx.snap
PrakashDurlabhji Jul 25, 2019
4aa72e5
Merge branch 'qa-accessibility' into issue_2873
PrakashDurlabhji Jul 26, 2019
22eb870
tests fix
PrakashDurlabhji Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions __tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,22 +652,29 @@ exports[`Render with specified profile 1`] = `
>
<div
className="src-shared-components-TopcoderHeader-___style__user-menu-handle___r6kbg"
role="button"
style={
Object {
"color": "#555555",
}
}
tabIndex={0}
/>
<div
className="src-shared-components-TopcoderHeader-___style__avatar___3BqbY"
<span
role="link"
tabIndex={0}
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
themePriority="adhoc-context-default"
/>
</div>
<div
className="src-shared-components-TopcoderHeader-___style__avatar___3BqbY"
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
themePriority="adhoc-context-default"
/>
</div>
</span>
</div>
<div
className="opened src-shared-components-TopcoderHeader-___style__search-icon___3w5nA"
Expand Down
4 changes: 3 additions & 1 deletion src/shared/components/TopcoderHeader/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,12 @@ export default class TopcoderHeader extends React.Component {
color: getRatingColor(_.get(normalizedProfile, 'maxRating.rating', 0)),
}}
styleName="user-menu-handle"
tabIndex={0}
role="button"
>
{normalizedProfile.handle}
</div>
{userAvatar}
<span role="link" tabIndex={0}>{userAvatar}</span>
</div>
);
} else {
Expand Down