fix issue #894 #1194
Merged
fix issue #894 #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue topcoder-platform#894 ABLE TO ADD INVALID OR INVALID FORMAT WEB URL IN ADD A WEB LINK.
|
@suppermancool this is not a correct way to do it. Now Also, the |
|
@ThomasKranitsas isWebLinkExist is bind in constructor, so you need to refresh the page before testing. Anyway i will change isWebLinkExist to webLinkExist in this PR, and fix the logic for url, pls wait until i finish |
fix regex for url link, change isWebLinkExist -> webLinkExist
|
@ThomasKranitsas i fixed the regex for url and change isWebLinkExist to webLinkExist, pls check, thanks |
|
@suppermancool please see the above screenshot |
|
Account: |
fix with some account link.URL is null
|
@ThomasKranitsas fixed, pls check again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #894
ABLE TO ADD INVALID OR INVALID FORMAT WEB URL IN ADD A WEB LINK.