Non task challenge is also not returned with task challenge

[vikasrohit]

@rootelement I think we don't yet support listing tasks (which are not assigned to the user) for a non admin user, however, I think the current logic is causing non task challenges to to missing from the response as well for non admin users. We have user pshah_manager who is not able to see tasks and challenge which were created using the same account. This user is not an admin but it did create few challenges some of which are tasks (few assigned to other users and few unassigned).

[vikasrohit]

@rootelement @ThomasKranitsas suggested a fix #277. I tried the query in postman by directly calling the ES endpoint but not tested the code itself. Further, I am not sure if it creates issue with any other use case e.g. public challenge listings or not.
Please feel free to discard it, if it is already thought upon and we know it is causing some regression.

[rootelement]

@vikasrohit I've merged the PR to dev. Please test there. If it looks good to you, we can have the QA team test as well.

[ThomasKranitsas]

@rootelement I think I found the issue.

If you check this https://api.topcoder-dev.com/v5/challenges/b91e4c01-ec46-404f-8691-aa631776d0e5

It has:

task: {
   isTask: true
},

Note that the isAssigned and memberId properties are missing and since the query is trying to match with { match_phrase: { 'task.isAssigned': false } }, it fails.
If that's actually the reason, we can simply fix it by adding default values to those fields (false and null respectively)

[rootelement]

@ThomasKranitsas is it better to add default values, or check for false OR non-existent?

[ThomasKranitsas]

I'd say better to add default values.. No need to over-complicate the query as that could have a performance impact

[ThomasKranitsas]

@rootelement should I fix this?

[rootelement]

Fixed in #292