Merge pull request #352 from topcoder-platform/lock-prizeSet-modification

rootelement · web-flow · commit d9050e741ffa · 2021-02-01T14:59:41.000-05:00
prevent changing prizes on completed challenges
diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js
@@ -1307,6 +1307,9 @@ async function update (currentUser, challengeId, data, isFull) {
   }
 
   if (data.prizeSets) {
+    if (isDifferentPrizeSets(data.prizeSets, challenge.prizeSets) && finalStatus === constants.challengeStatuses.Completed) {
+      throw new errors.BadRequestError(`Cannot update prizeSets for challenges with status: ${finalStatus}!`)
+    }
     const prizeSetsGroup = _.groupBy(data.prizeSets, 'type')
     if (!prizeSetsGroup[constants.prizeSetTypes.ChallengePrizes] && _.get(challenge, 'overview.totalPrizes')) {
       // remove the totalPrizes if challenge prizes are empty

Original file line number	Diff line number	Diff line change
`@@ -1307,6 +1307,9 @@ async function update (currentUser, challengeId, data, isFull) {`
`1307`	`1307`	`}`
`1308`	`1308`
`1309`	`1309`	`if (data.prizeSets) {`
	`1310`	`+ if (isDifferentPrizeSets(data.prizeSets, challenge.prizeSets) && finalStatus === constants.challengeStatuses.Completed) {`
	`1311`	+ throw new errors.BadRequestError(`Cannot update prizeSets for challenges with status: ${finalStatus}!`)
	`1312`	`+ }`
`1310`	`1313`	`const prizeSetsGroup = _.groupBy(data.prizeSets, 'type')`
`1311`	`1314`	`if (!prizeSetsGroup[constants.prizeSetTypes.ChallengePrizes] && _.get(challenge, 'overview.totalPrizes')) {`
`1312`	`1315`	`// remove the totalPrizes if challenge prizes are empty`