prevent changing prizes on completed challenges

ThomasKranitsas · ThomasKranitsas · commit d0552bf824b6 · 2020-12-17T17:52:18.000+02:00
diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js
@@ -1296,6 +1296,9 @@ async function update (currentUser, challengeId, data, userToken, isFull) {
   }
 
   if (data.prizeSets) {
+    if (isDifferentPrizeSets(data.prizeSets, challenge.prizeSets) && finalStatus === constants.challengeStatuses.Completed) {
+      throw new errors.BadRequestError(`Cannot update prizeSets for challenges with status: ${finalStatus}!`)
+    }
     const prizeSetsGroup = _.groupBy(data.prizeSets, 'type')
     if (!prizeSetsGroup[constants.prizeSetTypes.ChallengePrizes] && _.get(challenge, 'overview.totalPrizes')) {
       // remove the totalPrizes if challenge prizes are empty

Original file line number	Diff line number	Diff line change
`@@ -1296,6 +1296,9 @@ async function update (currentUser, challengeId, data, userToken, isFull) {`
`1296`	`1296`	`}`
`1297`	`1297`
`1298`	`1298`	`if (data.prizeSets) {`
	`1299`	`+ if (isDifferentPrizeSets(data.prizeSets, challenge.prizeSets) && finalStatus === constants.challengeStatuses.Completed) {`
	`1300`	+ throw new errors.BadRequestError(`Cannot update prizeSets for challenges with status: ${finalStatus}!`)
	`1301`	`+ }`
`1299`	`1302`	`const prizeSetsGroup = _.groupBy(data.prizeSets, 'type')`
`1300`	`1303`	`if (!prizeSetsGroup[constants.prizeSetTypes.ChallengePrizes] && _.get(challenge, 'overview.totalPrizes')) {`
`1301`	`1304`	`// remove the totalPrizes if challenge prizes are empty`