Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Sep 2, 2021

@phead198708 please review

@sachin-maheshwari
Copy link

@yoution @phead198708 I think you guys removed Zapier code which is required (https://github.com/topcoder-platform/taas-es-processor/blob/feature/shapeup4-cqrs-update2/src/services/JobProcessorService.js#L23).

we need to remove only those code/files, which is commented/not in used.

And accordingly we can clean-up the "readme or other doc" as well. Plan is make to rename this repo to "taas-event-processor".

Also can we replace "ES Get" to taas-API call. Example - https://github.com/topcoder-platform/taas-es-processor/blob/feature/shapeup4-cqrs-update2/src/services/JobCandidateProcessorService.js#L33

@yoution
Copy link
Contributor Author

yoution commented Sep 2, 2021

@sachin-maheshwari not the same project, currently is u-bahn-es, please check topcoder-platform/taas-es-processor#100,
for the taas-api call, I will change the code

@sachin-maheshwari
Copy link

@yoution Ahh. sorry

@sachin-maheshwari sachin-maheshwari changed the base branch from feature/shapeup-cqrs-update to feature/shapeup-cqrs-update2 September 2, 2021 07:34
@sachin-maheshwari sachin-maheshwari merged commit 5185e41 into topcoder-archive:feature/shapeup-cqrs-update2 Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants