Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Sync master with develop #71

Merged
merged 3 commits into from
Dec 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,10 @@ paths:
in: "query"
description: "The name of the skill"
type: "string"
- name: "orderBy"
in: "query"
type: "string"
description: "Specify by which field to sort by. Sorts in ascending order only"
responses:
"200":
description: "OK - the request was successful"
Expand Down
8 changes: 2 additions & 6 deletions src/common/es-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -1108,6 +1108,8 @@ async function searchElasticSearch (resource, ...args) {
if (params.orderBy) {
sortClause = sortClause.concat(await resolveSortClauseFromDb(params.orderBy, authUser, authUserOrganizationId))
}
} else if (params.orderBy) {
sortClause = [{ [`${params.orderBy}.keyword`]: 'asc' }]
}

// construct ES query
Expand Down Expand Up @@ -1279,18 +1281,14 @@ async function searchUsers (authUser, filter, params) {
const authUserOrganizationId = filter.organizationId
const filterKey = Object.keys(userFilters)

console.time('resolveUserFilterFromDb')
for (const key of filterKey) {
const resolved = await resolveUserFilterFromDb(userFilters[key], authUser, authUserOrganizationId)
resolvedUserFilters.push(resolved)
}
console.timeEnd('resolveUserFilterFromDb')

console.time('resolveSortClauseFromDb')
if (params.orderBy) {
sortClause = sortClause.concat(await resolveSortClauseFromDb(params.orderBy, authUser, authUserOrganizationId))
}
console.timeEnd('resolveSortClauseFromDb')

const esQuery = {
index: queryDoc.index,
Expand Down Expand Up @@ -1343,9 +1341,7 @@ async function searchUsers (authUser, filter, params) {
})

logger.debug(`ES query for searching users: ${JSON.stringify(esQuery, null, 2)}`)
console.time('mainesquery')
const { body: docs } = await esClient.search(esQuery)
console.timeEnd('mainesquery')
const result = docs.hits.hits.map(hit => hit._source)

return {
Expand Down
3 changes: 2 additions & 1 deletion src/modules/skill/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ const methods = helper.getServiceMethods(
{
skillProviderId: joi.string(),
name: joi.string(),
externalId: joi.string()
externalId: joi.string(),
orderBy: joi.string()
},
async query => {
const dbQueries = []
Expand Down